lingsamuel commented on code in PR #1787:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/1787#discussion_r1165299541


##########
Makefile:
##########
@@ -328,3 +330,44 @@ install-gateway-api-local:
 .PHONY: uninstall-gateway-api
 uninstall-gateway-api:
        kubectl delete -f $(GATEWAY_API_CRDS_LOCAL_PATH)
+
+### dev-env:                     Launch development environment
+.PHONY: dev-env
+dev-env: dev-kind-up dev-pack-image
+       helm repo add apisix https://charts.apiseven.com
+       helm repo update
+       helm install apisix apisix/apisix \
+               --set gateway.type=NodePort \
+               --set ingress-controller.enabled=true \
+               --namespace ingress-apisix \
+               --create-namespace
+       kubectl set image deployment/apisix-ingress-controller 
ingress-controller=$(DEV_REGISTRY)/apache/apisix-ingress-controller:dev 
--namespace ingress-apisix
+
+### dev-env-reset:        Reset development environment
+.PHONY: dev-env-reset
+dev-env-reset: kind-reset dev-clean-image
+
+### dev-kind-up:              Create a kind cluster with registry for dev
+.PHONY: dev-kind-up
+dev-kind-up:
+       ./utils/kind-with-registry.sh "8000"

Review Comment:
   The port shouldn't be hard-coded. But as I said, we don't need two 
registries, so I guess this line will be gone and doesn't affect anything.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to