monkeyDluffy6017 commented on code in PR #9210: URL: https://github.com/apache/apisix/pull/9210#discussion_r1165328560
########## apisix/plugins/log-rotate.lua: ########## @@ -266,11 +271,25 @@ local function rotate_file(files, now_time, max_kept) end +-- get the custom log file name from local_conf, if any +local function get_custom_logfile_name() + local local_conf = core.config.local_conf() + + local new_error_log = core.table.try_read_attr(local_conf, "nginx_config", "error_log") + local new_access_log = core.table.try_read_attr(local_conf, "nginx_config", "http", "access_log") Review Comment: Is `custom_error_log_name` or `error_log_name` better? The same with access log -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
