kingluo commented on code in PR #9329:
URL: https://github.com/apache/apisix/pull/9329#discussion_r1172063877


##########
apisix/cli/ngx_tpl.lua:
##########
@@ -833,6 +840,32 @@ http {
             proxy_pass $upstream_mirror_uri;
         }
         {% end %}
+
+        {% if enabled_plugins["proxy-mirror"] then %}
+        location = /proxy_mirror_grpc {
+            internal;
+
+            {% if not use_apisix_base then %}
+            if ($upstream_mirror_uri = "") {
+                return 200;
+            }
+            {% end %}
+
+
+            {% if proxy_mirror_timeouts then %}
+                {% if proxy_mirror_timeouts.connect then %}
+            proxy_connect_timeout {* proxy_mirror_timeouts.connect *};

Review Comment:
   Should use `grpc_*_timeout`
   http://nginx.org/en/docs/http/ngx_http_grpc_module.html#grpc_connect_timeout



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to