tao12345666333 commented on code in PR #1819:
URL:
https://github.com/apache/apisix-ingress-controller/pull/1819#discussion_r1180995988
##########
Makefile:
##########
@@ -150,7 +150,8 @@ e2e-test-local: kind-up e2e-test
.PHONY: ginkgo-check
ginkgo-check:
ifeq ("$(wildcard $(GINKGO))", "")
- @echo "ERROR: Need to install ginkgo first, run: go get -u
github.com/onsi/ginkgo/v2/[email protected] or go install -mod=mod
github.com/onsi/ginkgo/v2/[email protected]"
+ @echo "ERROR: Need to install ginkgo first, run: go get -u
github.com/onsi/ginkgo/v2/[email protected] and go install -mod=mod
github.com/onsi/ginkgo/v2/[email protected]"
Review Comment:
The go get installs for versions prior to Go 1.16.
And it can be installed via go install after 1.16
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
