Gallardot commented on PR #1822:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/1822#issuecomment-1534317028

   I find that the current goal of this PR to test is actually the same as the 
goal of 
[Test_validatePlugin](https://github.com/apache/apisix-ingress-controller/blob/2182a48cbca785373eca745a13d8cf2b7d9ab6c8/pkg/api/validation/apisix_route_test.go#L72)
 to test, but there are some differences in the test cases. Would it be nice to 
add some more test cases on top of 
[Test_validatePlugin](https://github.com/apache/apisix-ingress-controller/blob/2182a48cbca785373eca745a13d8cf2b7d9ab6c8/pkg/api/validation/apisix_route_test.go#L72)
 ?
   
   @khareyash05 @afzal442 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to