Sn0rt commented on code in PR #9425:
URL: https://github.com/apache/apisix/pull/9425#discussion_r1187072636
##########
apisix/plugins/syslog/init.lua:
##########
@@ -75,28 +79,32 @@ end
-- called in log phase of APISIX
function _M.push_entry(conf, ctx, entry)
- if batch_processor_manager:add_entry(conf, entry) then
+ local json_str, err = core.json.encode(entry)
+ if not json_str then
+ core.log.error('error occurred while encoding the data: ', err)
+ return
+ end
+
+ local rfc5424_data = rfc5424.encode("SYSLOG", "INFO", ctx.var.host,
+ "apisix", ctx.var.pid, json_str)
+
+ if batch_processor_manager:add_entry(conf, rfc5424_data) then
return
end
-- Generate a function to be executed by the batch processor
local cp_ctx = core.table.clone(ctx)
local func = function(entries, batch_max_size)
Review Comment:
the `batch_max_size` unused
##########
apisix/plugins/syslog/init.lua:
##########
@@ -75,28 +79,32 @@ end
-- called in log phase of APISIX
function _M.push_entry(conf, ctx, entry)
- if batch_processor_manager:add_entry(conf, entry) then
+ local json_str, err = core.json.encode(entry)
+ if not json_str then
+ core.log.error('error occurred while encoding the data: ', err)
+ return
+ end
+
+ local rfc5424_data = rfc5424.encode("SYSLOG", "INFO", ctx.var.host,
+ "apisix", ctx.var.pid, json_str)
+
+ if batch_processor_manager:add_entry(conf, rfc5424_data) then
return
end
-- Generate a function to be executed by the batch processor
local cp_ctx = core.table.clone(ctx)
local func = function(entries, batch_max_size)
- local data, err
- if batch_max_size == 1 then
- data, err = core.json.encode(entries[1]) -- encode as single {}
- else
- data, err = core.json.encode(entries) -- encode as array [{}]
- end
-
- if not data then
- return false, 'error occurred while encoding the data: ' .. err
+ local items = {}
+ for _, e in ipairs(entries) do
+ table.insert(items, e)
+ core.log.info("buffered logs:", e)
Review Comment:
maybe the log set with debug level is more suitable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
