monkeyDluffy6017 commented on code in PR #9388:
URL: https://github.com/apache/apisix/pull/9388#discussion_r1187136254
##########
apisix/init.lua:
##########
@@ -688,6 +689,13 @@ function _M.grpc_access_phase()
core.log.error("failed to set grpcs upstream param: ", err)
core.response.exit(code)
end
+
+ if api_ctx.var.upstream_mirror_scheme == "grpc" or
+ api_ctx.var.upstream_mirror_scheme == "grpcs" then
+ if has_mod then
+ apisix_ngx_client.enable_mirror()
+ end
+ end
Review Comment:
Why do you enable mirror here? it should be set in `proxy-mirror` plugin
If you enable here, I don't think the `sample_ratio` will work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
