heresie commented on code in PR #528:
URL: https://github.com/apache/apisix-helm-chart/pull/528#discussion_r1188232304


##########
charts/apisix/templates/configmap.yaml:
##########
@@ -69,14 +69,16 @@ data:
       enable_ipv6: {{ .Values.apisix.enableIPv6 }} # Enable nginx IPv6 resolver
       enable_server_tokens: {{ .Values.apisix.enableServerTokens }} # Whether 
the APISIX version number should be shown in Server header
 
-      # proxy_protocol:                   # Proxy Protocol configuration
-      #   listen_http_port: 9181          # The port with proxy protocol for 
http, it differs from node_listen and admin_listen.
-      #                                   # This port can only receive http 
request with proxy protocol, but node_listen & admin_listen
-      #                                   # can only receive http request. If 
you enable proxy protocol, you must use this port to
-      #                                   # receive http request with proxy 
protocol
-      #   listen_https_port: 9182         # The port with proxy protocol for 
https
-      #   enable_tcp_pp: true             # Enable the proxy protocol for tcp 
proxy, it works for stream_proxy.tcp option
-      #   enable_tcp_pp_to_upstream: true # Enables the proxy protocol to the 
upstream server
+      {{- if .Values.apisix.proxyProtocol.enabled }}
+      proxy_protocol:                                                          
# Proxy Protocol configuration
+        listen_http_port: {{ .Values.apisix.proxyProtocol.listenHttpPort }}    
# The port with proxy protocol for http, it differs from node_listen and 
port_admin.
+                                                                               
# This port can only receive http request with proxy protocol, but node_listen 
& port_admin
+                                                                               
# can only receive http request. If you enable proxy protocol, you must use 
this port to
+                                                                               
# receive http request with proxy protocol
+        listen_https_port: {{ .Values.apisix.proxyProtocol.listenHttpsPort }}  
# The port with proxy protocol for https
+        enable_tcp_pp: {{ .Values.apisix.proxyProtocol.enabled }}              
# Enable the proxy protocol for tcp proxy, it works for stream_proxy.tcp option

Review Comment:
   Hello @tao12345666333, thank you for the feedback.
   
   I'm afraid I don't understand what you mean by "new configuration item".
   I already match the reference configuration file 
(https://github.com/apache/apisix/blob/master/conf/config-default.yaml#L37-L44).
   
   Can you please be more specific?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to