kingluo commented on code in PR #9456:
URL: https://github.com/apache/apisix/pull/9456#discussion_r1191434579
##########
t/plugin/error-log-logger-skywalking.t:
##########
@@ -118,8 +118,8 @@ qr/Batch Processor\[error-log-logger\] failed to process
entries: error while se
--- request
GET /tg
--- response_body
---- error_log eval
-qr/.*\[\{\"body\":\{\"text\":\{\"text\":\".*this is an error message for
test.*\"\}\},\"endpoint\":\"\",\"service\":\"APISIX\",\"serviceInstance\":\"instance\".*/
Review Comment:
The new watch subsystem may print new logs.
All in all, strict log assumption is not a good practice.
##########
t/fuzzing/public.py:
##########
@@ -39,7 +39,10 @@ def check_log():
apisix_errorlog = apisix_pwd() + "/logs/error.log"
apisix_accesslog = apisix_pwd() + "/logs/access.log"
- cmds = ['cat %s | grep -a "error" | grep -v "invalid request
body"'%apisix_errorlog, 'cat %s | grep -a " 500 "'%apisix_accesslog]
+ cmds = ['cat %s | grep -a "error" \
Review Comment:
filter out timeout logs from upstream connections used for watching.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
