Revolyssup commented on issue #9458: URL: https://github.com/apache/apisix/issues/9458#issuecomment-1549079511
> @Revolyssup Hi, I have been sbumit [PR](https://github.com/apache/apisix/pull/9478). As metioned above, I just test it use vector as log server. So, I hope you can help me to test if this PR work correctly and imporve it. Thanks. > > It should be note that Splunk seems can receive json array as request body, otherwise, the previous tests should have failed. vector strictly aderes to `Splunk Event Data` format specification, because [this test](https://github.com/apache/apisix/blob/4419d0d8eb3daf901a1cf6fd4d2f806e579dced9/t/plugin/splunk-hec-logging.t#L189) will failed immediately before I fix this bug when I use vector as log server. So if splunk not strictly aderes to `Splunk Event Data` format specification, we also need to add other test case using vector as the log server. You can change the assertions in the test from data[1] to data to pass the failing ci tests. The tests currently are partially mocked. The responses in assertions come from mocked server whereas the splunk events are posted on actual splunk server. Using vector will ideally make the whole test real. For now you can just change the assertions as mentioned above and this will fix the immediate issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
