leslie-tsang commented on code in PR #9420: URL: https://github.com/apache/apisix/pull/9420#discussion_r1195822571
########## t/core/config_etcd.t: ########## @@ -233,44 +233,7 @@ passed -=== TEST 7: ensure only one auth request per subsystem for all the etcd sync ---- yaml_config -apisix: - node_listen: 1984 -deployment: - role: traditional - role_traditional: - config_provider: etcd - etcd: - host: - - "http://127.0.0.1:1980"; -- fake server port - timeout: 1 - user: root # root username for etcd - password: 5tHkHhYkjr6cQY # root password for etcd ---- extra_init_by_lua -local health_check = require("resty.etcd.health_check") -health_check.get_target_status = function() - return true -end ---- config - location /t { - content_by_lua_block { - ngx.sleep(0.5) - } - } ---- request -GET /t ---- grep_error_log eval -qr/etcd auth failed/ ---- grep_error_log_out -etcd auth failed Review Comment: We need a test case to make sure the fix work as expected. :) Plz add a new test case to prove it. ########## t/core/config_etcd.t: ########## @@ -233,44 +233,7 @@ passed -=== TEST 7: ensure only one auth request per subsystem for all the etcd sync ---- yaml_config -apisix: - node_listen: 1984 -deployment: - role: traditional - role_traditional: - config_provider: etcd - etcd: - host: - - "http://127.0.0.1:1980"; -- fake server port - timeout: 1 - user: root # root username for etcd - password: 5tHkHhYkjr6cQY # root password for etcd ---- extra_init_by_lua -local health_check = require("resty.etcd.health_check") -health_check.get_target_status = function() - return true -end ---- config - location /t { - content_by_lua_block { - ngx.sleep(0.5) - } - } ---- request -GET /t ---- grep_error_log eval -qr/etcd auth failed/ ---- grep_error_log_out -etcd auth failed Review Comment: BTW, it‘s weird to delete a test case in a fix PR without adding any new test case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
