Sn0rt commented on code in PR #9506:
URL: https://github.com/apache/apisix/pull/9506#discussion_r1198450840
##########
t/plugin/udp-logger.t:
##########
@@ -267,7 +267,7 @@ passedopentracing
qr/sending a batch logs to 127.0.0.1:(\d+)/
--- grep_error_log_out
sending a batch logs to 127.0.0.1:2000
-sending a batch logs to 127.0.0.1:2001
+sending a batch logs to 127.0.0.1:2002
Review Comment:
It’s okay, it’s better if a real udp logger is introduced to replace it
##########
t/plugin/udp-logger.t:
##########
@@ -410,10 +381,9 @@ the mock backend is hit
"port": 8125,
"tls": false,
"log_format": {
+ "case name": "logger format in plugin",
"vip": "$remote_addr"
- },
- "batch_max_size": 1,
- "inactive_timeout": 1
Review Comment:
not needed to remove .
##########
ci/pod/docker-compose.plugin.yml:
##########
Review Comment:
should I set the UDP port by `8125:8125/udp` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
