Sn0rt commented on code in PR #9526:
URL: https://github.com/apache/apisix/pull/9526#discussion_r1201615078


##########
t/plugin/splunk-hec-logging.t:
##########
@@ -406,19 +392,23 @@ the mock backend is hit
             if code >= 300 then
                 ngx.status = code
             end
-            ngx.say(body)
+            local code, _, body2 = t("/hello", "GET")
+            if code >= 300 then
+                ngx.status = code
+                ngx.say("fail")
+                return
+            end
+            ngx.say(passed)
         }
     }
+--- wait: 0.5
 --- response_body
 passed
 
 
 
-=== TEST 12: hit
---- pipelined_requests eval
-["GET /hello", "GET /hello", "GET /hello"]
---- wait: 2
+=== TEST 12: check splunk log
+--- exec
+tail -n 1 ci/pod/vector/splunk.log
 --- response_body eval
-["hello world\n", "hello world\n", "hello world\n"]
---- no_error_log
-[error]
+qr/.*test batched data.*/

Review Comment:
   new line



##########
ci/pod/docker-compose.plugin.yml:
##########
@@ -187,18 +187,6 @@ services:
     networks:
       opa_net:
 
-  # Splunk HEC Logging Service
-  splunk:

Review Comment:
   why remove this component? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to