apalapal opened a new pull request, #549:
URL: https://github.com/apache/apisix-helm-chart/pull/549

   The implementation of admin/view keys using kubernetes secret on #530 
doesn't seem to work.
   What happens is that on the resulting config.yaml file, the admin key ( and 
viewer ) will look like:
         - name: "admin"
           key: "{{APISIX_ADMIN_KEY}}" 
   
   instead of the ' key: ${{APISIX_ADMIN_KEY}} '   that is described on 
[https://apisix.apache.org/docs/apisix/admin-api/](https://apisix.apache.org/docs/apisix/admin-api/).
   The result is that the admin key is literally the value string above and not 
the value from the env/k8s secret.
   -
   This PR is the fix on the config map to have the proper key value format to 
reference the env variable ( filled from the configured secretName secret).
   
   This change was tested, where the admin and viewer keys were correctly set 
and looked like this on the final config.yaml:
   
   ...
         - name: "admin"
           key: ${{APISIX_ADMIN_KEY}}
   ...
         - name: "viewer"
           key: ${{APISIX_VIEWER_KEY}}  
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to