joyyir commented on code in PR #548: URL: https://github.com/apache/apisix-helm-chart/pull/548#discussion_r1213857619
########## charts/apisix/values.yaml: ########## @@ -157,6 +157,16 @@ apisix: # key: KEY extraEnvVars: [] + # -- Set the readinessProbe for Apache APISIX pods + readinessProbe: + failureThreshold: 6 + initialDelaySeconds: 10 + periodSeconds: 10 + successThreshold: 1 + tcpSocket: + port: &gatewayHttpContainerPort 9080 Review Comment: I used `YAML Anchors` to refer to the same values. Wouldn't you recommend it? https://helm.sh/docs/chart_template_guide/yaml_techniques/#yaml-anchors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
