monkeyDluffy6017 commented on code in PR #9606:
URL: https://github.com/apache/apisix/pull/9606#discussion_r1220821886
##########
apisix/plugins/grpc-transcode/response.lua:
##########
@@ -99,7 +99,10 @@ return function(ctx, proto, service, method, pb_option,
show_status_in_body, sta
-- handle error response after the last response chunk
if ngx.status >= 300 and show_status_in_body then
- return handle_error_response(status_detail_type)
+ local pb_old_state = pb.state(proto.pb_state)
+ local ret = handle_error_response(status_detail_type)
+ pb.state(pb_old_state)
Review Comment:
Why not do this in `handle_error_response` function, `around pd.decode` like
other place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
