kingluo commented on code in PR #9334:
URL: https://github.com/apache/apisix/pull/9334#discussion_r1222422756
##########
apisix/router.lua:
##########
@@ -22,31 +22,297 @@ local plugin_checker =
require("apisix.plugin").plugin_checker
local str_lower = string.lower
local error = error
local ipairs = ipairs
-
+local sub_str = string.sub
+local table = require("apisix.core.table")
+local json = require("apisix.core.json")
+local router_util = require("apisix.utils.router")
+local tab_insert = table.insert
local _M = {version = 0.3}
+local function empty_func() end
-local function filter(route)
- route.orig_modifiedIndex = route.modifiedIndex
- route.update_count = 0
+local function push_host_router(route, host_routes, only_uri_routes)
Review Comment:
export and reuse push_host_router() in radixtree_host_uri.lua.
##########
apisix/router.lua:
##########
@@ -70,7 +336,6 @@ local function attach_http_router_common_methods(http_router)
end
end
-
Review Comment:
revert blank line delete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]