skimdz86 commented on code in PR #9365:
URL: https://github.com/apache/apisix/pull/9365#discussion_r1223076619
##########
apisix/plugins/cors.lua:
##########
@@ -202,9 +244,12 @@ local function set_cors_headers(conf, ctx)
if conf.allow_credential then
core.response.set_header("Access-Control-Allow-Credentials", true)
end
+ if ctx.timing_allow_origin then
Review Comment:
you want to separate the block for the standard CORS and the if about the
timing, correct? So a blank line between 246 and 247
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
