monkeyDluffy6017 commented on code in PR #9619: URL: https://github.com/apache/apisix/pull/9619#discussion_r1230383802
########## apisix/plugins/log-rotate.lua: ########## @@ -46,8 +46,10 @@ local COMPRESSION_FILE_SUFFIX = ".tar.gz" -- compression file suffix local rotate_time local default_logs local enable_compression = false -local DEFAULT_ACCESS_LOG_FILENAME = "access.log" -local DEFAULT_ERROR_LOG_FILENAME = "error.log" +local DEFAULT_ACCESS_LOG_FILENAME = "logs/access.log" +local DEFAULT_ERROR_LOG_FILENAME = "logs/error.log" Review Comment: I think it's better not to change this, the variable name is `FILENAME`, it should not include the file path -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
