kindomLee commented on PR #9622:
URL: https://github.com/apache/apisix/pull/9622#issuecomment-1595646518
> Could you add `client_email` to the all test file,
`google-cloud-logging.t`, `google-cloud-logging2.t`?
Sorry, I'm not very familiar with the lua testing framework, this part
might need some other partners to help
> > We need to set up Google authentication to authenticate to Logging
>
> Could you create a issue about this?
I should say this, we have already provided two ways to read Google
authentication when using the google cloud logging plugin, which are calling
and passing in `auth_config` and reading the file `auth_file`[1]. When reading
auth_file, the google client_email field is there so it won't cause any
problems; but when authenticating through auth_config, because the default
documentation description skips the client_mail setting, that's why it will
cause an error. I don't think we need to raise another authentication issue
[1]
https://github.com/apache/apisix/blob/7ec3c0f583510ebcdf9c414f83792e1ac247a5b9/apisix/plugins/google-cloud-logging.lua#L138
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
