tao12345666333 commented on code in PR #478:
URL: https://github.com/apache/apisix-docker/pull/478#discussion_r1244706865


##########
debian/Dockerfile:
##########
@@ -48,7 +48,7 @@ WORKDIR /usr/local/apisix
 
 ENV 
PATH=$PATH:/usr/local/openresty/luajit/bin:/usr/local/openresty/nginx/sbin:/usr/local/openresty/bin
 
-RUN useradd -u 1001 apisix && chown -R apisix:apisix /usr/local/apisix
+RUN useradd --system --no-create-home --home /nonexistent --shell /bin/false 
--uid 636 apisix && chown -R apisix:apisix /usr/local/apisix

Review Comment:
   Executing "groupadd" before this would be better. 
   And use `--shell /usr/sbin/nologin` instead of `/bin/false`
   
   We don't need `--home /nonexistent`, because we already use the 
`--no-create-home`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to