Revolyssup commented on code in PR #9580:
URL: https://github.com/apache/apisix/pull/9580#discussion_r1254192393
##########
apisix/admin/plugins.lua:
##########
@@ -42,7 +44,15 @@ end
function _M.get(name)
local arg = get_uri_args()
- if arg and arg["all"] == "true" then
+ -- If subsystem is passed inside args then it should be oneOf: http /
stream.
+ local subsystem = arg["subsystem"]
+ if subsystem and subsystem ~= "http" and subsystem ~= "stream" then
+ return 400, {error_msg = "unsupported subsystem: "..subsystem}
+ end
+
+ -- arg all to be deprecated
+ if (arg and arg["all"] == "true") or not name then
Review Comment:
@monkeyDluffy6017 This condition is so that `/plugins` can also return what
`/plugins?all=true` returns currently. Adding this or condition is important to
make the behaviour of `/plugins` == behaviour of `plugins?all=true`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
