monkeyDluffy6017 commented on code in PR #9663:
URL: https://github.com/apache/apisix/pull/9663#discussion_r1254215913
##########
apisix/plugins/limit-conn/init.lua:
##########
@@ -101,33 +98,46 @@ function _M.increase(conf, ctx)
end
end
-
function _M.decrease(conf, ctx)
local limit_conn = ctx.limit_conn
if not limit_conn then
return
end
+ local is_http = ctx.config.subsystem == "http"
+ if not is_http then
+ core.log.warn("The limit-conn plugin is not applicable in stream mode")
+ return
+ end
Review Comment:
Why not put this on the top of the file, it could cache the result and no
need to judge every time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
