shreemaan-abhishek commented on code in PR #9720:
URL: https://github.com/apache/apisix/pull/9720#discussion_r1255391195


##########
t/plugin/mocking.t:
##########
@@ -424,3 +424,44 @@ passed
 GET /hello
 --- response_body chomp
 empty_var:
+
+
+
+=== TEST 19: set route(return headers)
+--- config
+       location /t {
+           content_by_lua_block {
+               local t = require("lib.test_admin").test
+               local code, body = t('/apisix/admin/routes/1',
+                    ngx.HTTP_PUT,
+                    [[{
+                           "plugins": {
+                               "mocking": {
+                                   "response_example": "hello world",
+                                   "response_headers": {
+                                        "X-Apisix": "is-cool",
+                                        "X-Really":"yes"

Review Comment:
   1. Only the last one is retained, the first one is lost. However, if someone 
needs multiple values for a header they can do `"header-name": "val1, val2"`.
   
   2. Why is this test case needed?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to