monkeyDluffy6017 commented on code in PR #9778:
URL: https://github.com/apache/apisix/pull/9778#discussion_r1259521079
##########
apisix/plugins/consumer-restriction.lua:
##########
@@ -86,7 +86,11 @@ local fetch_val_funcs = {
}
local function is_include(value, tab)
- for k,v in ipairs(tab) do
+ if not value then
+ return false
+ end
Review Comment:
You are right, but it's too complicated to check every scenario, let's make
the logic simple, the user who use the plugin should ensure that the assigned
type is present in every request.
So i think it's ok to optimize the related error log
```
Missing authentication or identity verification
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
