jiangfucheng commented on code in PR #9841:
URL: https://github.com/apache/apisix/pull/9841#discussion_r1264435704


##########
apisix/plugins/ua-restriction.lua:
##########
@@ -97,6 +95,10 @@ function _M.check_schema(conf)
         return false, err
     end
 
+    if conf.allowlist and conf.denylist then
+        return false, "allowlist and denylist can't be enabled at the same 
time."
+    end

Review Comment:
   I tried using `oneOf` field of jsonschema to validate configuration, but 
it's seems can't meet us requirement(Perhaps there is a problem with my usage). 
So, use code to check it directly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to