monkeyDluffy6017 commented on code in PR #9841:
URL: https://github.com/apache/apisix/pull/9841#discussion_r1266147601
##########
apisix/plugins/ua-restriction.lua:
##########
@@ -58,6 +54,22 @@ local schema = {
default = "Not allowed"
},
},
+ oneOf = {
+ {
+ required = {"allowlist"}
+ },
+ {
+ required = {"denylist"}
+ },
+ {
+ ["not"] = {
+ anyOf = {
+ {required = {"allowlist"}},
+ {required = {"denylist"}}
+ }
+ }
+ }
Review Comment:
I don't know why we configure like this, no allowlist and no denylist, it is
meanless
```
"plugins": {
"ua-restriction": {
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
