jiangfucheng commented on code in PR #9843:
URL: https://github.com/apache/apisix/pull/9843#discussion_r1266768784
##########
apisix/plugins/tencent-cloud-cls/cls-sdk.lua:
##########
@@ -62,8 +62,15 @@ local params_cache = {
local function get_ip(hostname)
local _, resolved = socket.dns.toip(hostname)
local ip_list = {}
- for _, v in ipairs(resolved.ip) do
- insert_tab(ip_list, v)
+ if not resolved.ip then
Review Comment:
It seems can't resolve this problem.
```
# Failed test 't/plugin/tencent-cloud-cls.t TEST 10: log use log_format -
pattern "[error]" should not match any line in error.log but matches line
"2023/07/18 21:16:48 [error] 28051\#33045887: *50 [lua] resolver.lua:80:
parse_domain(): failed to parse domain: jiangfuchengdeMacBook-Pro.local, error:
failed to query the DNS server: dns server error: 3 name error, context:
ngx.timer, client: 127.0.0.1, server: 0.0.0.0:1984" (req 0)
```
If we can't merge this temporary fix, I will investigate the reasons for the
failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
