soulbird commented on code in PR #256:
URL:
https://github.com/apache/apisix-java-plugin-runner/pull/256#discussion_r1266940883
##########
runner-core/src/main/java/org/apache/apisix/plugin/runner/handler/RpcCallHandler.java:
##########
@@ -229,7 +212,7 @@ private void handleExtraInfo(ChannelHandlerContext ctx,
ExtraInfoResponse reques
}
} else if (EXTRA_INFO_RESP_BODY_KEY.equals(varsKey)) {
if (!Objects.isNull(postReq)) {
- postReq.setBody(result);
+ postReq.setBody( new String(result));
Review Comment:
A PR is best to do only one thing, this seems to be no need to modify
##########
runner-plugin-sdk/src/main/java/org/apache/apisix/plugin/runner/PostResponse.java:
##########
@@ -126,8 +152,4 @@ public void setBody(String body) {
public void setStatusCode(int statusCode) {
this.statusCode = statusCode;
}
-
- public void setCharset(Charset charset) {
Review Comment:
Why delete this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
