Revolyssup commented on code in PR #1907:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/1907#discussion_r1278888038


##########
docs/en/latest/FAQ.md:
##########
@@ -88,3 +88,12 @@ You can change the Admin API key in two ways:
 
 1. Modify the key in both 
[apisix/values.yaml](https://github.com/apache/apisix-helm-chart/blob/57cdbe461765cd49af2195cc6a1976cc55262e9b/charts/apisix/values.yaml#L181)
 and 
[apisix/apisix-ingress-controller/values.yaml](https://github.com/apache/apisix-helm-chart/blob/57cdbe461765cd49af2195cc6a1976cc55262e9b/charts/apisix-ingress-controller/values.yaml#L128)
 files.
 2. You can also set this imperatively by passing the flag `--set 
ingress-controller.config.apisix.adminKey=<new key> --set 
admin.credentials.admin=<new key>` to the `helm install` command.
+
+
+## Why does my Ingress resource not have an address?
+
+You will need to get the apisix-gateway service an external IP assigned for it 
to reflect on the Ingress's status.
+1. While installing APISIX helm chart make sure to override gateway type with 
`--set gateway.type=LoadBalancer`. 

Review Comment:
   Applied suggestion



##########
docs/en/latest/FAQ.md:
##########
@@ -88,3 +88,12 @@ You can change the Admin API key in two ways:
 
 1. Modify the key in both 
[apisix/values.yaml](https://github.com/apache/apisix-helm-chart/blob/57cdbe461765cd49af2195cc6a1976cc55262e9b/charts/apisix/values.yaml#L181)
 and 
[apisix/apisix-ingress-controller/values.yaml](https://github.com/apache/apisix-helm-chart/blob/57cdbe461765cd49af2195cc6a1976cc55262e9b/charts/apisix-ingress-controller/values.yaml#L128)
 files.
 2. You can also set this imperatively by passing the flag `--set 
ingress-controller.config.apisix.adminKey=<new key> --set 
admin.credentials.admin=<new key>` to the `helm install` command.
+
+
+## Why does my Ingress resource not have an address?
+
+You will need to get the apisix-gateway service an external IP assigned for it 
to reflect on the Ingress's status.
+1. While installing APISIX helm chart make sure to override gateway type with 
`--set gateway.type=LoadBalancer`. 
+2. Also make sure to pass ingressPublishService while installing Ingress 
controller with `--set 
ingress-controller.config.ingressPublishService=apisix-gateway`

Review Comment:
   Applied suggestion



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to