[GitHub] [apisix] wxbty commented on pull request #9660: feat: add dubbo protocols support for xrpc

[via GitHub]

wxbty commented on PR #9660:
URL: https://github.com/apache/apisix/pull/9660#issuecomment-1661428467

   > The codes looks good to me now.
   > 
   > But looks like we the xrpc test cases never be run?
   > 
   > <img alt="image" width="915" 
src="https://user-images.githubusercontent.com/33000667/257679431-5b868b5a-5abd-4b1e-bddb-223588e83056.png";>
 <img alt="image" width="1046" 
src="https://user-images.githubusercontent.com/33000667/257679508-99bf004b-8552-43bb-9672-877a83d632b3.png";>
   > Please have a look, thanks! @wxbty
   
   
   
   We need to start a dubbo backend service, and I reused the backend service 
corresponding to plugin/dubbo. In CI, the corresponding services are 
automatically started in the .github/workflows/build.yml file as follows:
            name: Start Dubbo Backend
            if: matrix.os_name == 'linux_openresty' && 
[steps.test_env.outputs.type == 'plugin' || steps.test_env.outputs.type == 
'xrpc']
            run: |
              sudo apt install -y maven
              cd t/lib/dubbo-backend
              mvn package
              cd dubbo-backend-provider/target
              java -Djava.net.preferIPv4Stack=true -jar 
dubbo-demo-provider.one-jar.jar > /tmp/java.log &
   
   
   If we need to test in local, we can manually start dubbo-backend follow the 
same steps, and then we can pass the test.
   
   
![image](https://github.com/apache/apisix/assets/38374721/ce62400f-36b1-4bee-b837-c2cd2da3ff77)
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org