jiangfucheng commented on code in PR #9967:
URL: https://github.com/apache/apisix/pull/9967#discussion_r1285068907


##########
t/core/config_etcd.t:
##########
@@ -443,3 +443,81 @@ qr/readdir key: fake res: 
\{.*"nodes":\[\{.*"value":\["bar"\].*\}\].*\}/
 --- wait: 1
 --- no_error_log
 [error]
+
+
+
+=== TEST 13: test route with special character "-"

Review Comment:
   Add all tests in one "TEST" because we need to ensure nginx not be reloaded 
to cover this bug.



##########
t/core/config_etcd.t:
##########
@@ -443,3 +443,81 @@ qr/readdir key: fake res: 
\{.*"nodes":\[\{.*"value":\["bar"\].*\}\].*\}/
 --- wait: 1
 --- no_error_log
 [error]
+
+
+
+=== TEST 13: test route with special character "-"
+--- yaml_config
+deployment:
+  role: traditional
+  role_traditional:
+    config_provider: etcd
+  admin:
+    admin_key: null
+  etcd:
+    prefix: "/apisix-test"
+--- config
+    location /t {
+        content_by_lua_block {
+            ngx.sleep(0.5)

Review Comment:
   This sleep is to wait for the watch thread to start, according to my 
testing, APISIX can't watch data if we send data immediately after APISIX 
starts. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to