jiangfucheng commented on code in PR #9909: URL: https://github.com/apache/apisix/pull/9909#discussion_r1285906693
########## apisix/core/config_etcd.lua: ########## @@ -257,6 +260,33 @@ local function run_watch(premature) end +local function run_watch(premature) + local run_watch_th = ngx_thread_spawn(do_run_watch, premature) + + ::restart:: + local check_worker_th = ngx_thread_spawn(function () + while not exiting() do + ngx_sleep(0.1) + end + end) + + local ok, err = ngx_thread_wait(check_worker_th) Review Comment: The `do_run_watch` function will not return, it has an internal retry mechanism. The origin logic did not handle this so I didn't do this either. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
