darkSheep404 commented on code in PR #9948:
URL: https://github.com/apache/apisix/pull/9948#discussion_r1288303273
##########
docs/en/latest/plugins/openid-connect.md:
##########
@@ -61,6 +61,7 @@ description: OpenID Connect allows the client to obtain user
information from th
| session | object | False |
| | When bearer_only is set to false, openid-connect will use
Authorization Code flow to authenticate on the IDP, so you need to set the
session-related configuration. |
| session.secret | string | True | Automatic
generation | 16 or more characters | The key used for session encrypt and HMAC
operation. |
| unauth_action | string | False | "auth"
| | Specify the response type on unauthenticated requests.
"auth" redirects to identity provider, "deny" results in a 401 response, "pass"
will allow the request without authentication. |
+| proxy_opts | object | False |
| | Configure an HTTP proxy to be used with the
openid-connect plugin. |
Review Comment:
hi @Sn0rt
by the way
I noticed that you modified the desc in openid-connect schema
by using `https://proxy-server` instead of `http://proxy-server` for
`https_proxy` .
I changed it back in this commit
Because when I did that before in our project, it caused an exception
`protocol https not supported for proxy connections`
I fix it by set `https_proxy` = `http://proxy-server` instead of
`https://proxy-server` .
In addition I noticed some hardcoded special handling in the
`lua-resty-http` source code say https is not support,like below
We may need to confirm this disagreement
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
