Revolyssup commented on code in PR #9770:
URL: https://github.com/apache/apisix/pull/9770#discussion_r1293139493
##########
apisix/discovery/dns/init.lua:
##########
@@ -64,14 +64,14 @@ end
function _M.init_worker()
local local_conf = config_local.local_conf()
local servers = local_conf.discovery.dns.servers
-
+ local resolvconf = local_conf.discovery.dns.resolvconf
local default_order = {"last", "SRV", "A", "AAAA", "CNAME"}
local order = core.table.try_read_attr(local_conf, "discovery", "dns",
"order")
order = order or default_order
local opts = {
hosts = {},
- resolvConf = {},
+ resolvConf = resolvconf,
Review Comment:
okay except for the `resolveConf` inside opts because that field is in the
lua-resty-dns.
##########
apisix/discovery/dns/init.lua:
##########
@@ -64,14 +64,14 @@ end
function _M.init_worker()
local local_conf = config_local.local_conf()
local servers = local_conf.discovery.dns.servers
-
+ local resolvconf = local_conf.discovery.dns.resolvconf
local default_order = {"last", "SRV", "A", "AAAA", "CNAME"}
local order = core.table.try_read_attr(local_conf, "discovery", "dns",
"order")
order = order or default_order
local opts = {
hosts = {},
- resolvConf = {},
+ resolvConf = resolvconf,
Review Comment:
okay except for the `resolveConf` key inside opts because that field is in
the lua-resty-dns.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
