Revolyssup commented on PR #10066: URL: https://github.com/apache/apisix/pull/10066#issuecomment-1687412221
> Could you explain the reason for the bug? why can't it be reproduced in the old version? And test cases are needed @monkeyDluffy6017 Here[1] on version 3.3, `match_and_set` is called during verification and if matched is nil then it will skip verification and the nil error will never happen. Here[2] on version 3.4, we try to extract `matched_ssl` from `ngx.ctx` and directly use it without nil check. This will be non nil only at the time of ssl handshake and after that it will be nil causing error. 1. https://github.com/apache/apisix/blob/d4e9b36dccec249e81733ebe6ee6df228a6e9a85/apisix/init.lua#L290 2. https://github.com/apache/apisix/blob/04b8bca4b60667aae45c463b7122b2dc1f4e70f2/apisix/init.lua#L331 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
