Sn0rt commented on code in PR #9930:
URL: https://github.com/apache/apisix/pull/9930#discussion_r1301085726


##########
t/cli/test_admin_mtls.sh:
##########
@@ -53,3 +53,45 @@ if [ ! "$code" -eq 400 ]; then
 fi
 
 echo "passed: enabled mTLS for admin"
+
+make stop
+
+echo '
+deployment:
+    admin:
+        admin_listen:
+            port: 9180
+        https_admin: true
+        admin_api_mtls:
+            admin_ssl_cert: "$secret://apisix_config/admin_ssl_cert"
+            admin_ssl_cert_key: "$secret://apisix_config/admin_ssl_cert_key"
+            admin_ssl_ca_cert: "$secret://apisix_config/admin_ssl_ca_cert"
+    secret_vault:
+        enable: true
+        uri: "http://127.0.0.1:8200";
+        prefix: "kv/apisix"
+        token: "${{VAULT_TOKEN}}"
+' > conf/config.yaml
+
+VAULT_TOKEN='root' VAULT_ADDR='http://0.0.0.0:8200' vault kv put 
kv/apisix/apisix_config admin_ssl_cert=@./t/certs/mtls_server.crt 
admin_ssl_cert_key=@./t/certs/mtls_server.key 
admin_ssl_ca_cert=@./t/certs/mtls_ca.crt

Review Comment:
   ```diff
   diff --git a/.github/workflows/cli.yml b/.github/workflows/cli.yml
   index 7aa65540..4cde0dfe 100644
   --- a/.github/workflows/cli.yml
   +++ b/.github/workflows/cli.yml
   @@ -53,6 +53,7 @@ jobs:
          - name: Linux launch common services
            run: |
              project_compose_ci=ci/pod/docker-compose.common.yml make ci-env-up
   +          sudo ./ci/init-common-test-service.sh
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to