leslie-tsang commented on code in PR #9983:
URL: https://github.com/apache/apisix/pull/9983#discussion_r1303894594
##########
t/plugin/opentelemetry4-bugfix-pb-state.t:
##########
@@ -102,11 +81,13 @@ __DATA__
if code >= 300 then
ngx.status = code
end
- ngx.say(body)
+ ngx.say("done")
Review Comment:
Why change the output verify ?
##########
Makefile:
##########
@@ -450,6 +451,7 @@ compress-tar:
.PHONY: ci-env-up
ci-env-up:
@$(call func_echo_status, "$@ -> [ Start ]")
+ touch $(OTEL_CONFIG); chmod 777 $(OTEL_CONFIG)
Review Comment:
```suggestion
touch $(OTEL_CONFIG)
chmod 777 $(OTEL_CONFIG)
```
One cmd for one thing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
