Revolyssup commented on PR #10050:
URL: https://github.com/apache/apisix/pull/10050#issuecomment-1691265670

   update: this needs some further consideration.
   1. The password is logged at other places as well when debug mode is info. 
It is stored in plain-text in route configuration as well. 
   2. If looking at error log is a security issue then user can just as easily 
GET for the route configuration and see the password. 
   @monkeyDluffy6017 What do you think? Is it worth to hide that password from 
few parts of the log. 
   
   Since, the type of this password is "Plain text" and it is stored as such. 
It looks hacky to remove it at only certain places. This can still appear in 
log. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to