Yiyiyimu commented on a change in pull request #2282:
URL: https://github.com/apache/apisix/pull/2282#discussion_r493242304



##########
File path: apisix/plugins/batch-requests.lua
##########
@@ -45,7 +45,7 @@ local req_schema = {
         timeout = {
             description = "pipeline timeout(ms)",
             type = "integer",
-            default = 30000,
+            default = 3000,

Review comment:
       > 1. Default timeout in 
[code](https://github.com/apache/apisix/blob/master/apisix/plugins/batch-requests.lua#L48)
 is set to 30000. but in 
[doc](https://github.com/apache/apisix/blob/master/apisix/plugins/batch-requests.lua#L48)
 it's 3000.
   
   update `doc` is better.
   
   _Originally posted by @membphis in 
https://github.com/apache/apisix/issues/2262#issuecomment-697154388_
   
   ---
   
   Since I turned to update the doc but not the code, I think we could keep 
them in one PR.
   And thank you @juzhiyuan I write a summary. It was too messy without the 
list.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to