kayx23 commented on code in PR #9050:
URL: https://github.com/apache/apisix/pull/9050#discussion_r1309743937


##########
docs/en/latest/admin-api.md:
##########
@@ -1312,6 +1312,12 @@ Plugin resource request address: 
/apisix/admin/plugins/{plugin_name}
 | ------ | ----------------------------------- | ------------ | 
---------------------------------------------- |
 | GET    | /apisix/admin/plugins/list          | NULL         | Fetches a list 
of all Plugins.                 |
 | GET    | /apisix/admin/plugins/{plugin_name} | NULL         | Fetches the 
specified Plugin by `plugin_name`. |
+| GET         | /apisix/admin/plugins?all=true      | NULL         | Get all 
properties of all plugins. |
+| GET         | /apisix/admin/plugins?all=true&subsystem=stream| NULL | Gets 
properties of all Stream plugins.|
+| GET    | /apisix/admin/plugins?all=true&subsystem=http | NULL | Gets 
properties of all HTTP plugins. |
+| PUT    | /apisix/admin/plugins/reload       | NULL         | Reloads the 
plugin according to the changes made in code |
+| GET    | apisix/admin/plugins/{PLUGIN}?subsystem=stream | NULL | Gets the 
`{PLUGIN}` schema if it is supported in Stream/L4 subsystem. |

Review Comment:
   ```suggestion
   | GET    | apisix/admin/plugins/{plugin_name}?subsystem=stream | NULL | Gets 
properties of a specified plugin if it is supported in Stream/L4 subsystem. |
   ```



##########
docs/en/latest/admin-api.md:
##########
@@ -1312,6 +1312,12 @@ Plugin resource request address: 
/apisix/admin/plugins/{plugin_name}
 | ------ | ----------------------------------- | ------------ | 
---------------------------------------------- |
 | GET    | /apisix/admin/plugins/list          | NULL         | Fetches a list 
of all Plugins.                 |
 | GET    | /apisix/admin/plugins/{plugin_name} | NULL         | Fetches the 
specified Plugin by `plugin_name`. |
+| GET         | /apisix/admin/plugins?all=true      | NULL         | Get all 
properties of all plugins. |

Review Comment:
   Add deprecate note for `all=true`.
   
   @Revolyssup btw, does `apisix/admin/plugins` do what 
`/apisix/admin/plugins?all=true` do after the change? Or is the subsystem URL 
param _required_ for the`/apisix/admin/plugins` endpoint
   



##########
docs/zh/latest/admin-api.md:
##########
@@ -1326,6 +1326,8 @@ Plugin 资源请求地址:/apisix/admin/plugins/{plugin_name}
 | GET         | /apisix/admin/plugins/{plugin_name} | 无         | 获取资源。      |
 | GET         | /apisix/admin/plugins?all=true      | 无         | 获取所有插件的所有属性。 
|
 | GET         | /apisix/admin/plugins?all=true&subsystem=stream| 无 | 获取所有 
Stream 插件的属性。|
+| GET         | /apisix/admin/plugins?all=true&subsystem=http| 无 | 获取所有 HTTP 
插件的属性。|
+| PUT         | /apisix/admin/plugins/reload        | 无         | 
根据代码中所做的更改重新加载插件 |

Review Comment:
   ```suggestion
   | PUT         | /apisix/admin/plugins/reload        | 无         | 
根据代码中所做的更改重新加载插件。 |
   | GET         | apisix/admin/plugins/{plugin_name}?subsystem=stream         
| 无         | 获取指定 Stream 插件的属性。 |
   | GET         | apisix/admin/plugins/{plugin_name}?subsystem=http         | 
无         | 获取指定 HTTP 插件的属性。 |
   ```



##########
docs/en/latest/admin-api.md:
##########
@@ -1312,6 +1312,12 @@ Plugin resource request address: 
/apisix/admin/plugins/{plugin_name}
 | ------ | ----------------------------------- | ------------ | 
---------------------------------------------- |
 | GET    | /apisix/admin/plugins/list          | NULL         | Fetches a list 
of all Plugins.                 |
 | GET    | /apisix/admin/plugins/{plugin_name} | NULL         | Fetches the 
specified Plugin by `plugin_name`. |
+| GET         | /apisix/admin/plugins?all=true      | NULL         | Get all 
properties of all plugins. |
+| GET         | /apisix/admin/plugins?all=true&subsystem=stream| NULL | Gets 
properties of all Stream plugins.|
+| GET    | /apisix/admin/plugins?all=true&subsystem=http | NULL | Gets 
properties of all HTTP plugins. |
+| PUT    | /apisix/admin/plugins/reload       | NULL         | Reloads the 
plugin according to the changes made in code |
+| GET    | apisix/admin/plugins/{PLUGIN}?subsystem=stream | NULL | Gets the 
`{PLUGIN}` schema if it is supported in Stream/L4 subsystem. |
+| GET    | apisix/admin/plugins/{PLUGIN}?subsystem=http   | NULL | Gets the 
`{PLUGIN}` schema if it is supported in HTTP/L7 subsystem. |

Review Comment:
   ```suggestion
   | GET    | apisix/admin/plugins/{PLUGIN}?subsystem=http   | NULL | Gets 
properties of a specified plugin if it is supported in HTTP/L7 subsystem. |
   ```



##########
docs/zh/latest/admin-api.md:
##########
@@ -1326,6 +1326,8 @@ Plugin 资源请求地址:/apisix/admin/plugins/{plugin_name}
 | GET         | /apisix/admin/plugins/{plugin_name} | 无         | 获取资源。      |
 | GET         | /apisix/admin/plugins?all=true      | 无         | 获取所有插件的所有属性。 
|
 | GET         | /apisix/admin/plugins?all=true&subsystem=stream| 无 | 获取所有 
Stream 插件的属性。|
+| GET         | /apisix/admin/plugins?all=true&subsystem=http| 无 | 获取所有 HTTP 
插件的属性。|
+| PUT         | /apisix/admin/plugins/reload        | 无         | 
根据代码中所做的更改重新加载插件 |

Review Comment:
   ```suggestion
   | PUT         | /apisix/admin/plugins/reload        | 无         | 
根据代码中所做的更改重新加载插件。 |
   | GET         | apisix/admin/plugins/{plugin_name}?subsystem=stream         
| 无         | 获取指定 Stream 插件的属性。 |
   | GET         | apisix/admin/plugins/{plugin_name}?subsystem=http         | 
无         | 获取指定 HTTP 插件的属性。 |
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to