navendu-pottekkat commented on code in PR #10126:
URL: https://github.com/apache/apisix/pull/10126#discussion_r1314285390
##########
docs/en/latest/plugins/kafka-logger.md:
##########
@@ -47,7 +47,7 @@ It might take some time to receive the log data. It will be
automatically sent a
| brokers.sasl_config.password | string | True | |
| The password of sasl_config. If sasl_config exists, it's
required.
|
| kafka_topic | string | True | |
| Target topic to push the logs for organisation.
|
| producer_type | string | False | async | ["async",
"sync"] | Message sending mode of the producer.
|
-| required_acks | integer | False | 1 | [0, 1, -1]
| Number of acknowledgements the leader needs to receive for the
producer to consider the request complete. This controls the durability of the
sent records. The attribute follows the same configuration as the Kafka `acks`
attribute. See [Apache Kafka
documentation](https://kafka.apache.org/documentation/#producerconfigs_acks)
for more. |
+| required_acks | integer | False | 1 | [1, -1]
| Number of acknowledgements the leader needs to receive for the producer
to consider the request complete. This controls the durability of the sent
records. The attribute follows the same configuration as the Kafka `acks`
attribute. required_acks does not support 0 yet. See [Apache Kafka
documentation](https://kafka.apache.org/documentation/#producerconfigs_acks)
for more. |
Review Comment:
```suggestion
| required_acks | integer | False | 1 | [1, -1]
| Number of acknowledgements the leader needs to receive for the
producer to consider the request complete. This controls the durability of the
sent records. The attribute follows the same configuration as the Kafka `acks`
attribute. `required_acks` cannot be 0. See [Apache Kafka
documentation](https://kafka.apache.org/documentation/#producerconfigs_acks)
for more. |
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
