AlinsRan commented on code in PR #10198:
URL: https://github.com/apache/apisix/pull/10198#discussion_r1325318361
##########
apisix/http/router/radixtree_host_uri.lua:
##########
@@ -162,12 +161,12 @@ end
function _M.matching(api_ctx)
core.log.info("route match mode: radixtree_host_uri")
- core.table.clear(match_opts)
+ local match_opts = core.tablepool.fetch("route_match_opts", 0, 16)
match_opts.method = api_ctx.var.request_method
match_opts.remote_addr = api_ctx.var.remote_addr
match_opts.vars = api_ctx.var
match_opts.host = api_ctx.var.host
- match_opts.matched = core.tablepool.fetch("matched_route_record", 0, 4)
Review Comment:
Nesting memory requests from tablepool is a bad practice and requires
attention to the relationship between child and parent tables.
It may sacrifice some performance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
