[GitHub] [apisix] monkeyDluffy6017 commented on a diff in pull request #10232: change: creating core resources does not allow passing in `create_time` and `update_time`

Fri, 22 Sep 2023 10:35:21 -0700 


monkeyDluffy6017 commented on code in PR #10232:
URL: https://github.com/apache/apisix/pull/10232#discussion_r1334659958


##########
apisix/admin/resource.lua:
##########
@@ -49,7 +49,41 @@ local function split_typ_and_id(id, sub_path)
 end
 
 
-function _M:check_conf(id, conf, need_id, typ)
+local function check_create_update_time(conf)

Review Comment:
   Why do you need to differentiate each resource?
   Why not do like the function `utils.iinject_timestamp`?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to