kamly commented on code in PR #508:
URL: https://github.com/apache/apisix-docker/pull/508#discussion_r1338752884


##########
centos/docker-entrypoint.sh:
##########
@@ -31,11 +31,8 @@ deployment:
     config_provider: yaml
 _EOC_
       else
-          wget -qO /usr/local/apisix/yq 
https://github.com/mikefarah/yq/releases/latest/download/yq_linux_amd64 \
-               && chmod a+x /usr/local/apisix/yq
-          /usr/local/apisix/yq -i '.deployment.role = "data_plane"' 
${PREFIX}/conf/config.yaml
-          /usr/local/apisix/yq -i '.deployment.role_data_plane.config_provider 
= "yaml"' ${PREFIX}/conf/config.yaml 
-          rm /usr/local/apisix/yq
+          sed -i 's/role: traditional/role: data_plane/' config.yaml

Review Comment:
   Sorry for replying to you so late.
   
   I think there may be other `role` configurations in config , such as:
   ```
   test:
      role: xxx
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to