Revolyssup commented on code in PR #9806:
URL: https://github.com/apache/apisix/pull/9806#discussion_r1339552111
##########
apisix/upstream.lua:
##########
@@ -282,6 +282,19 @@ function _M.set_by_route(route, api_ctx)
end
up_conf.nodes = new_nodes
+ -- fill node info before clone
+ if not is_http then
+ local ok, err = fill_node_info(up_conf, nil, true)
+ if not ok then
+ return 503, err
Review Comment:
can you change this to 502? This is what's failing the test
##########
apisix/upstream.lua:
##########
@@ -282,6 +282,19 @@ function _M.set_by_route(route, api_ctx)
end
up_conf.nodes = new_nodes
+ -- fill node info before clone
+ if not is_http then
+ local ok, err = fill_node_info(up_conf, nil, true)
+ if not ok then
+ return 503, err
+ end
+ else
+ local ok, err = fill_node_info(up_conf,
api_ctx.upstream_scheme, false)
+ if not ok then
+ return 503, err
Review Comment:
dittto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
