monkeyDluffy6017 commented on code in PR #10361:
URL: https://github.com/apache/apisix/pull/10361#discussion_r1366525869
##########
apisix/plugins/zipkin.lua:
##########
@@ -51,7 +55,12 @@ local schema = {
span_version = {
enum = {ZIPKIN_SPAN_VER_1, ZIPKIN_SPAN_VER_2},
default = ZIPKIN_SPAN_VER_2,
- },
+ },
+ set_ngx_var = {
+ type = "boolean",
+ description = "set nginx variables",
+ default = false,
+ },
Review Comment:
Why do you add the check here? Are you going to pass this configuration in
the plugin parameters?？It is unnecessary if you just want to define the
configuration in `config.yaml`
##########
apisix/plugins/zipkin.lua:
##########
@@ -51,7 +55,12 @@ local schema = {
span_version = {
enum = {ZIPKIN_SPAN_VER_1, ZIPKIN_SPAN_VER_2},
default = ZIPKIN_SPAN_VER_2,
- },
+ },
+ set_ngx_var = {
+ type = "boolean",
+ description = "set nginx variables",
+ default = false,
+ },
Review Comment:
Why do you add the check here? Are you going to pass this configuration in
the plugin parameters?？It is unnecessary if you just want to define the
configuration in `config.yaml`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
