Revolyssup commented on PR #8884: URL: https://github.com/apache/apisix/pull/8884#issuecomment-1783875599
This PR requires to add a field in this file https://github.com/api7/ext-plugin-proto/blob/4af76c210e00ead699489cfeb055d8b9bb7596ed/ext-plugin.fbs#L121 @moonming @shreemaan-abhishek @monkeyDluffy6017 As far as I can see, this PR and https://github.com/apache/apisix/pull/9990 are kind of similar. Both set the request's body but at different stage. The one that is merged sets the request body by signalling it in the response of the RPC. After that the request is sent to the upstream. This PR on the other hand allows to set the request body using handle_extra_info function which facilitates communication between plugin runner and APISIX while the plugin runner is still processing the request. Here after the request is set, the request won't be sent to upstream immediately as the Reply isn't yet sent by the plugin runner. The plugin runner can do some more things. Conclusion: According to me, this PR is not required because after the request is set to something, why should plugin runner do anything else on it. It doesn't seem like something that should happen with handle_extra_info. This can be achieved by the reply of the HTTPReq RPC call. @hongdingyi In case I am missing some scenario where this actually will be required and just setting the request body using the Reply of the RPC wouldn't justify the use case, please let me know. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
