moonming commented on a change in pull request #2294:
URL: https://github.com/apache/apisix/pull/2294#discussion_r494036709
##########
File path: bin/apisix
##########
@@ -1025,7 +1025,7 @@ local function init_etcd(show_output)
for _, dir_name in ipairs({"/routes", "/upstreams", "/services",
"/plugins", "/consumers", "/node_status",
"/ssl", "/global_rules", "/stream_routes",
- "/proto"}) do
+ "/proto", "/plugin_metadata"}) do
Review comment:
What is the difference between metadata and the properties of plugin
itself? I didn't see why we need it.
##########
File path: bin/apisix
##########
@@ -1025,7 +1025,7 @@ local function init_etcd(show_output)
for _, dir_name in ipairs({"/routes", "/upstreams", "/services",
"/plugins", "/consumers", "/node_status",
"/ssl", "/global_rules", "/stream_routes",
- "/proto"}) do
+ "/proto", "/plugin_metadata"}) do
Review comment:
https://github.com/apache/apisix/pull/2294#issuecomment-698108183
##########
File path: bin/apisix
##########
@@ -1025,7 +1025,7 @@ local function init_etcd(show_output)
for _, dir_name in ipairs({"/routes", "/upstreams", "/services",
"/plugins", "/consumers", "/node_status",
"/ssl", "/global_rules", "/stream_routes",
- "/proto"}) do
+ "/proto", "/plugin_metadata"}) do
Review comment:
why we need this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
