kayx23 commented on code in PR #10413: URL: https://github.com/apache/apisix/pull/10413#discussion_r1376911487
########## docs/en/latest/terminology/route.md: ########## @@ -36,6 +36,12 @@ A Route mainly consists of three parts: 2. Plugin configuration (current-limit, rate-limit) 3. Upstream information +:::note + +APISIX also supports GraphQL based route filtering, [see here](../../latest/router-radixtree.md#how-to-filter-route-by-graphql-attributes). Review Comment: While the [radix tree doc](https://apisix.apache.org/docs/apisix/router-radixtree) is indeed hard to find, I found it a bit strange to drop an admonition here just for "graphql based route filtering". In fact all these are not mentioned:  and what's missing from the above doc is the mention of APISIX variables (in addition to NGINX variables) I would also see if we can mention these information in this doc without admonitions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
